metatensor-operations finite difference test for add
#479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here is a pre-built version of the code in this pull request: wheels.zip, you can install it locally by unzipping |
agoscinski
commented
Feb 2, 2024
python/metatensor-operations/metatensor/operations/testing/_grad.py
Outdated
Show resolved
Hide resolved
4 tasks
Luthaf
reviewed
Feb 2, 2024
python/metatensor-operations/metatensor/operations/testing/_creation_operation.py
Outdated
Show resolved
Hide resolved
DavideTisi
reviewed
Feb 2, 2024
python/metatensor-operations/metatensor/operations/testing/_grad.py
Outdated
Show resolved
Hide resolved
python/metatensor-operations/metatensor/operations/testing/_creation_operation.py
Outdated
Show resolved
Hide resolved
agoscinski
force-pushed
the
add-gradcheck
branch
6 times, most recently
from
fe3b83c
to
78a824a
Compare
agoscinski
force-pushed
the
add-gradcheck
branch
from
78a824a
to
884ab63
Compare
DavideTisi
approved these changes
Feb 5, 2024
agoscinski
force-pushed
the
add-gradcheck
branch
from
884ab63
to
0246ca9
Compare
DavideTisi
approved these changes
Feb 5, 2024
Luthaf
reviewed
Feb 5, 2024
python/metatensor-operations/metatensor/operations/_testing/_creation_operation.py
Outdated
Show resolved
Hide resolved
python/metatensor-operations/metatensor/operations/_testing/_creation_operation.py
Outdated
Show resolved
Hide resolved
python/metatensor-operations/metatensor/operations/_testing/_grad.py
Outdated
Show resolved
Hide resolved
python/metatensor-operations/metatensor/operations/block_from_array.py
Outdated
Show resolved
Hide resolved
4 tasks
Luthaf
force-pushed
the
add-gradcheck
branch
2 times, most recently
from
a9f6e9a
to
200ff10
Compare
|
@DavideTisi do you want to give this one last look? It should then be good to go! |
|
Thanks! |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds utilities for doing finite difference tests for the metatensor-operations and uses them in the simple example of the
addoperation.This is the first PR addressing issue #84
The idea of the testing utilities originates from issue #469
In the next run on this PR I want to dispatch the testing utilities so they can also be used for torch, but before that I would like to have some general feedback if this is going in a good direction.
TODOs:
cartesian_linearneeds to be implementedContributor (creator of pull-request) checklist
Reviewer checklist
📚 Documentation preview 📚: https://metatensor--479.org.readthedocs.build/en/479/
📚 Download documentation preview for this pull-request